Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(621)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2993113002: Add crash comments in dart2js_extra and dart2js_native (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 4 months ago
Reviewers:
Emily Fortuna, sra1
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add crash comments in dart2js_extra and dart2js_native BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/4d53ef3449d17b057502c8b87f176730f1ba9609

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -273 lines) Patch
M tests/compiler/dart2js_extra/dart2js_extra.status View 7 chunks +131 lines, -174 lines 1 comment Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 chunk +99 lines, -99 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2993113002/diff/1/tests/compiler/dart2js_extra/dart2js_extra.status File tests/compiler/dart2js_extra/dart2js_extra.status (left): https://codereview.chromium.org/2993113002/diff/1/tests/compiler/dart2js_extra/dart2js_extra.status#oldcode182 tests/compiler/dart2js_extra/dart2js_extra.status:182: 21579_test: RuntimeError these were dupes I accidentally added when ...
3 years, 4 months ago (2017-08-04 20:26:49 UTC) #2
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-04 20:28:47 UTC) #4
Emily Fortuna
I read every line. lgtm
3 years, 4 months ago (2017-08-04 20:30:23 UTC) #5
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-04 20:30:59 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
4d53ef3449d17b057502c8b87f176730f1ba9609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698