Add support for SDK outline in KernelDriver.

pkg/front_end/test/src/incremental/kernel_driver_test.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 
 import 'package:front_end/compiler_options.dart';
 import 'package:front_end/memory_file_system.dart';
 import 'package:front_end/src/base/performace_logger.dart';
 import 'package:front_end/src/base/processed_options.dart';
 import 'package:front_end/src/fasta/kernel/utils.dart';
 import 'package:front_end/src/fasta/uri_translator_impl.dart';
 import 'package:front_end/src/incremental/byte_store.dart';
 import 'package:front_end/src/incremental/kernel_driver.dart';
+import 'package:front_end/src/kernel_generator_impl.dart';
 import 'package:kernel/ast.dart';
 import 'package:kernel/binary/ast_from_binary.dart';
 import 'package:kernel/target/targets.dart';
 import 'package:kernel/text/ast_to_text.dart';
 import 'package:kernel/verifier.dart';
 import 'package:package_config/src/packages_impl.dart';
 import 'package:test/test.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 
 import 'mock_sdk.dart';
@@ skipping 254 matching lines @@
   test_compile_typeEnvironment() async {
     writeFile('/test/.packages', 'test:lib/');
     String aPath = '/test/lib/a.dart';
     Uri aUri = writeFile(aPath, 'class A {}');
 
     KernelResult result = await driver.getKernel(aUri);
     expect(result.types.coreTypes.intClass, isNotNull);
     expect(result.types.hierarchy, isNotNull);
   }
 
+  test_compile_useSdkOutline() async {
+    List<int> sdkOutlineBytes = await _computeSdkOutlineBytes();
+
+    // Configure the driver to use the SDK outline.
+    _createDriver(sdkOutlineBytes: sdkOutlineBytes);
+
+    writeFile('/test/.packages', 'test:lib/');
+    String aPath = '/test/lib/a.dart';
+    Uri aUri = writeFile(aPath, r'''
+import 'dart:async';
+var a = 1;
+Future<String> b;
+''');
+
+    KernelResult result = await driver.getKernel(aUri);
+
+    // The result does not include SDK libraries.
+    _assertLibraryUris(result,
+        includes: [aUri],
+        excludes: [Uri.parse('dart:core'), Uri.parse('dart:core')]);
+
+    // The types of top-level variables are resolved.
+    var library = _getLibrary(result, aUri);
+    expect(library.fields[0].type.toString(), 'dart.core::int');
+    expect(library.fields[1].type.toString(),
+        'dart.async::Future<dart.core::String>');
+  }
+
   test_limitedStore_exportDependencies() async {
     writeFile('/test/.packages', 'test:lib/');
     String aPath = '/test/lib/a.dart';
     String bPath = '/test/lib/b.dart';
     String cPath = '/test/lib/c.dart';
     Uri aUri = writeFile(aPath, 'class A {}');
     var bUri = writeFile(bPath, 'export "a.dart";');
     Uri cUri = writeFile(cPath, r'''
 import 'b.dart';
 A a;
@@ skipping 341 matching lines @@
         .expand((uris) => uris)
         .toList();
     for (var shouldInclude in includes) {
       expect(libraryUris, contains(shouldInclude));
     }
     for (var shouldExclude in excludes) {
       expect(libraryUris, isNot(contains(shouldExclude)));
     }
   }
 
+  Future<List<int>> _computeSdkOutlineBytes() async {
+    var options = new CompilerOptions()
+      ..fileSystem = fileSystem
+      ..compileSdk = true
+      ..strongMode = true
+      ..sdkRoot = Uri.parse('file:///sdk/')
+      ..target = new NoneTarget(new TargetFlags(strongMode: true));
+    var inputs = [Uri.parse('dart:core')];
+    var result = await generateKernel(

[Siggi Cherem (dart-lang), 2017/08/05 03:22:47]

any reason why not use the public API instead? (`summaryFor(inputs, options)`)?

[scheglov, 2017/08/06 21:04:06]

Well, this is what build uses.
And an attempt to use summaryFor() results in an exception.
---
file:///sdk/lib/core/core.dart: Error: Invalid access to
file:///sdk/lib/core/core.dart: the file is accessed in a modular hermetic
build, but it was not explicitly listed as an input.
---

[Siggi Cherem (dart-lang), 2017/08/07 15:29:52]

Hopefully just setting `options.chaseDependencies = true` should fix that (the
default is false when using the `summaryFor` API).

[scheglov, 2017/08/07 15:51:26]

Yes, this fixed the problem.

+        new ProcessedOptions(options, false, inputs),
+        buildSummary: true);
+    return result.summary;
+  }
+
   /// Create new [KernelDriver] instance and put it into the [driver] field.
   void _createDriver(
-      {Map<String, Uri> packages, KernelDriverFileAddedFn fileAddedFn}) {
+      {List<int> sdkOutlineBytes,
+      Map<String, Uri> packages,
+      KernelDriverFileAddedFn fileAddedFn}) {
     Map<String, Uri> dartLibraries = createSdkFiles(fileSystem);
     var uriTranslator =
         new UriTranslatorImpl(dartLibraries, {}, new MapPackages(packages));
-    driver = new KernelDriver(
-        new ProcessedOptions(new CompilerOptions()
-          ..logger = new PerformanceLog(null)
-          ..fileSystem = fileSystem
-          ..byteStore = new MemoryByteStore()
-          ..strongMode = true
-          ..target = new NoneTarget(new TargetFlags(strongMode: true))),
-        uriTranslator,
-        fileAddedFn: fileAddedFn);
+
+    var options = new CompilerOptions()
+      ..logger = new PerformanceLog(null)
+      ..fileSystem = fileSystem
+      ..byteStore = new MemoryByteStore()
+      ..strongMode = true
+      ..target = new NoneTarget(new TargetFlags(strongMode: true));
+
+    driver = new KernelDriver(new ProcessedOptions(options), uriTranslator,
+        sdkOutlineBytes: sdkOutlineBytes, fileAddedFn: fileAddedFn);
   }
 
   Library _getLibrary(KernelResult result, Uri uri) {
     for (var cycleResult in result.results) {
       for (var library in cycleResult.kernelLibraries) {
         if (library.importUri == uri) return library;
       }
     }
     throw fail('No library found with URI "$uri"');
   }
@@ skipping 11 matching lines @@
         .writeLibraryFile(library);
     return buffer.toString();
   }
 
   /// Return the [Uri] for the given Posix [path].
   static Uri _folderUri(String path) {
     if (!path.endsWith('/')) path += '/';
     return Uri.parse('file://$path');
   }
 }