Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2993093002: package barback: Update the comment style generic syntax. (Closed)

Created:
3 years, 4 months ago by keertip
Modified:
3 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix code #

Patch Set 3 : fix code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -49 lines) Patch
M lib/src/asset/asset_node.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M lib/src/graph/package_graph.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/src/graph/phase.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/transformer/aggregate_transform.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/utils.dart View 1 2 9 chunks +26 lines, -35 lines 0 comments Download
M lib/src/utils/cancelable_future.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
keertip
3 years, 4 months ago (2017-08-04 17:25:03 UTC) #3
kevmoo
I saw a weird replacement here Do the tests pass? https://codereview.chromium.org/2993093002/diff/1/lib/src/transformer/aggregate_transform.dart File lib/src/transformer/aggregate_transform.dart (right): https://codereview.chromium.org/2993093002/diff/1/lib/src/transformer/aggregate_transform.dart#newcode84 ...
3 years, 4 months ago (2017-08-04 17:29:03 UTC) #4
keertip
https://codereview.chromium.org/2993093002/diff/1/lib/src/transformer/aggregate_transform.dart File lib/src/transformer/aggregate_transform.dart (right): https://codereview.chromium.org/2993093002/diff/1/lib/src/transformer/aggregate_transform.dart#newcode84 lib/src/transformer/aggregate_transform.dart:84: return getInput(id).thenserveCommand<Future<String>>( On 2017/08/04 17:29:03, kevmoo wrote: > ??? ...
3 years, 4 months ago (2017-08-04 17:52:01 UTC) #5
kevmoo
On 2017/08/04 17:52:01, keertip wrote: > https://codereview.chromium.org/2993093002/diff/1/lib/src/transformer/aggregate_transform.dart > File lib/src/transformer/aggregate_transform.dart (right): > > https://codereview.chromium.org/2993093002/diff/1/lib/src/transformer/aggregate_transform.dart#newcode84 > ...
3 years, 4 months ago (2017-08-04 17:52:36 UTC) #6
keertip
On 2017/08/04 17:52:36, kevmoo wrote: > On 2017/08/04 17:52:01, keertip wrote: > > > https://codereview.chromium.org/2993093002/diff/1/lib/src/transformer/aggregate_transform.dart ...
3 years, 4 months ago (2017-08-04 18:11:08 UTC) #7
kevmoo
lgtm
3 years, 4 months ago (2017-08-04 18:15:07 UTC) #8
keertip
3 years, 4 months ago (2017-08-04 18:38:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1b99dc20ffc1ba7f60695032955c2eb8afe484cb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698