Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2993083002: Normalize status files for dart2js_with_kernel (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 4 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Normalize status files for dart2js_with_kernel This is only moving status lines around to ensure we only have 2 sections for $dart2js_with_kernel per file: minified and host-checked. Some entries are now duplicated because we no longer have the $dart2js_with_kernel (non-checked) section. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/edc1054ae14c227282e3aad7cc5b24ae35c43359

Patch Set 1 : v1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2753 lines, -747 lines) Patch
M tests/compiler/dart2js_extra/dart2js_extra.status View 4 chunks +210 lines, -49 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 2 chunks +114 lines, -5 lines 0 comments Download
M tests/corelib/corelib.status View 8 chunks +147 lines, -13 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 7 chunks +259 lines, -175 lines 0 comments Download
M tests/language/language_dart2js.status View 53 chunks +1545 lines, -239 lines 0 comments Download
M tests/language_2/language_2.status View 4 chunks +478 lines, -266 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-04 16:28:58 UTC) #3
Emily Fortuna
lgtm! Is there some sort of script or something we should run to keep this ...
3 years, 4 months ago (2017-08-04 16:32:23 UTC) #4
Siggi Cherem (dart-lang)
Committed patchset #1 (id:20001) manually as edc1054ae14c227282e3aad7cc5b24ae35c43359 (presubmit successful).
3 years, 4 months ago (2017-08-04 16:41:14 UTC) #6
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-08-04 17:22:19 UTC) #7
Message was sent while issue was closed.
On 2017/08/04 16:32:23, Emily Fortuna wrote:
> lgtm!
> Is there some sort of script or something we should run to keep this in this
> format? Or do we just ensure we maintain alphabetical order when we add
things?

Almost - I hope to answer yes by the end of the day.

Powered by Google App Engine
This is Rietveld 408576698