Split language_2.status into multiple files.

Split language_2.status into multiple files.

This mainly splits along compiler lines, but uses runtime for a couple
of things -- VM and Flutter mainly.

I did most of the work automatically by hacking up the migration script
to re-migrate the existing file, but I also went through and manually
cleaned the result up as best I could.

R=bkonyi@google.com, jcollins@google.com

Committed: https://github.com/dart-lang/sdk/commit/9a0c11c26b9bcca706ffd295f707aada4ebce1e5

[Bob Nystrom, 2017-08-04 06:07:16]

rnystrom@google.com changed reviewers:
+ bkonyi@google.com, whesse@google.com

[Bob Nystrom, 2017-08-04 06:07:16]

Assuming this looks OK to you, I'll try to land it relative early Friday morning
before more changes to language_2.status happen in the meantime.

I'll do the same thing to corelib tomorrow, and I'll send out the
changes to the migration script in a separate CL.

[Bob Nystrom, 2017-08-04 17:47:19]

rnystrom@google.com changed reviewers:
+ jcollins@google.com

[bkonyi, 2017-08-04 17:49:00]

bkonyi@google.com changed reviewers:
- jcollins@google.com

[bkonyi, 2017-08-04 17:49:01]

LGTM! Looks easier to read already :)

https://codereview.chromium.org/2993043002/diff/1/tools/migration/bin/check_f...
File tools/migration/bin/check_for_splits.dart (right):

https://codereview.chromium.org/2993043002/diff/1/tools/migration/bin/check_f...
tools/migration/bin/check_for_splits.dart:14: void main(List<String> arguments)
{
What's the point of this tool here exactly?

[jcollins, 2017-08-04 17:57:31]

jcollins@google.com changed reviewers:
+ jcollins@google.com

[jcollins, 2017-08-04 17:57:32]

lgtm

https://codereview.chromium.org/2993043002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_kernel.status (right):

https://codereview.chromium.org/2993043002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_kernel.status:168: [ $compiler == none || $compiler
== app_jit || $compiler == dartk || $runtime == dart_precompiled ]
I think I would prefer it if entries that could go in more than one of the
sub-files be dropped into the corelib_2.status file, instead.

Besides being something reasonably easy to automate, it'll also be easier when
browsing the multiple files -- at least then there's only two files to check if
you're looking for something with dartk: it'll either be in this file, or the
main one (rather than whichever file the user manually moved it to).

[jcollins, 2017-08-04 17:57:53]

On 2017/08/04 17:57:32, jcollins wrote:
> lgtm
> 
>
https://codereview.chromium.org/2993043002/diff/1/tests/language_2/language_2...
> File tests/language_2/language_2_kernel.status (right):
> 
>
https://codereview.chromium.org/2993043002/diff/1/tests/language_2/language_2...
> tests/language_2/language_2_kernel.status:168: [ $compiler == none ||
$compiler
> == app_jit || $compiler == dartk || $runtime == dart_precompiled ]
> I think I would prefer it if entries that could go in more than one of the
> sub-files be dropped into the corelib_2.status file, instead.
> 
> Besides being something reasonably easy to automate, it'll also be easier when
> browsing the multiple files -- at least then there's only two files to check
if
> you're looking for something with dartk: it'll either be in this file, or the
> main one (rather than whichever file the user manually moved it to).

s/corelib_2/language_2/

[Bob Nystrom, 2017-08-04 18:31:44]

Thanks!

https://codereview.chromium.org/2993043002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2_kernel.status (right):

https://codereview.chromium.org/2993043002/diff/1/tests/language_2/language_2...
tests/language_2/language_2_kernel.status:168: [ $compiler == none || $compiler
== app_jit || $compiler == dartk || $runtime == dart_precompiled ]
On 2017/08/04 17:57:31, jcollins wrote:
> I think I would prefer it if entries that could go in more than one of the
> sub-files be dropped into the corelib_2.status file, instead.

Ah, yes, this one shouldn't be here. Split it into two sections, one in _kernel
and one in _precompiled.

Since compiler takes precedence over runtime, the migration script saw "compiler
== dartk" and ignored the "runtime == dart_precompiled" part.

> Besides being something reasonably easy to automate, it'll also be easier when
> browsing the multiple files -- at least then there's only two files to check
if
> you're looking for something with dartk: it'll either be in this file, or the
> main one (rather than whichever file the user manually moved it to).

+1.

https://codereview.chromium.org/2993043002/diff/1/tools/migration/bin/check_f...
File tools/migration/bin/check_for_splits.dart (right):

https://codereview.chromium.org/2993043002/diff/1/tools/migration/bin/check_f...
tools/migration/bin/check_for_splits.dart:14: void main(List<String> arguments)
{
On 2017/08/04 17:49:01, bkonyi wrote:
> What's the point of this tool here exactly?

Oops, that was a temp script for me. Didn't mean to add it. Deleted.

[Bob Nystrom, 2017-08-04 18:33:05]

Description was changed from

==========
Split language_2.status into multiple files.

This mainly splits along compiler lines, but uses runtime for a couple
of things -- VM and Flutter mainly.

I did most of the work automatically by hacking up the migration script
to re-migrate the existing file, but I also went through and manually
cleaned the result up as best I could.
==========

to

==========
Split language_2.status into multiple files.

This mainly splits along compiler lines, but uses runtime for a couple
of things -- VM and Flutter mainly.

I did most of the work automatically by hacking up the migration script
to re-migrate the existing file, but I also went through and manually
cleaned the result up as best I could.

R=bkonyi@google.com, jcollins@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9a0c11c26b9bcca706ffd295f707aada4ebce1e5
==========

[Bob Nystrom, 2017-08-04 18:33:06]

Committed patchset #2 (id:20001) manually as
9a0c11c26b9bcca706ffd295f707aada4ebce1e5 (presubmit successful).