Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: tokenserver/appengine/impl/serviceaccounts/config_validation_test.go

Issue 2993023002: tokenserver: Boilerplate for loading and serving service_accounts.cfg. (Closed)
Patch Set: add test Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tokenserver/appengine/impl/serviceaccounts/config_validation_test.go
diff --git a/tokenserver/appengine/impl/serviceaccounts/config_validation_test.go b/tokenserver/appengine/impl/serviceaccounts/config_validation_test.go
new file mode 100644
index 0000000000000000000000000000000000000000..19c104d5c87396f6ce7e94cc38a6111e0f16e0fd
--- /dev/null
+++ b/tokenserver/appengine/impl/serviceaccounts/config_validation_test.go
@@ -0,0 +1,89 @@
+// Copyright 2017 The LUCI Authors.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package serviceaccounts
+
+import (
+ "testing"
+
+ "github.com/golang/protobuf/proto"
+
+ "github.com/luci/luci-go/tokenserver/api/admin/v1"
+ "github.com/luci/luci-go/tokenserver/appengine/impl/utils/policy"
+
+ "github.com/luci/luci-go/common/config/validation"
+ . "github.com/luci/luci-go/common/testing/assertions"
+ . "github.com/smartystreets/goconvey/convey"
+)
+
+func TestValidation(t *testing.T) {
+ t.Parallel()
+
+ cases := []struct {
+ Cfg string
+ Errors []string
+ }{
+ {
+ Cfg: `
+ rules {
+ name: "rule 1"
+ owner: "developer@example.com"
+ service_account: "abc@robots.com"
+ allowed_scope: "https://scope"
+ end_user: "user:abc@example.com"
+ end_user: "group:group-name"
+ proxy: "user:proxy@example.com"
+ max_grant_validity_duration: 3600
+ }
+
+ rules {
+ name: "rule 2"
+ owner: "developer@example.com"
+ service_account: "def@robots.com"
+ allowed_scope: "https://scope"
+ end_user: "user:abc@example.com"
+ end_user: "group:group-name"
+ proxy: "user:proxy@example.com"
+ max_grant_validity_duration: 3600
+ }
+ `,
+ },
+
+ // TODO(vadimsh): Add more cases.
+ }
+
+ Convey("Validation works", t, func(c C) {
+ for idx, cs := range cases {
+ c.Printf("Case #%d\n", idx)
+
+ cfg := &admin.ServiceAccountsPermissions{}
+ err := proto.UnmarshalText(cs.Cfg, cfg)
+ So(err, ShouldBeNil)
+
+ ctx := validation.Context{}
+ validateConfigs(policy.ConfigBundle{serviceAccountsCfg: cfg}, &ctx)
+ verr := ctx.Finalize()
+
+ if len(cs.Errors) == 0 { // no errors expected
+ So(verr, ShouldBeNil)
+ } else {
+ verr := verr.(*validation.Error)
+ So(len(verr.Errors), ShouldEqual, len(cs.Errors))
+ for i, err := range verr.Errors {
+ So(err, ShouldErrLike, cs.Errors[i])
+ }
+ }
+ }
+ })
+}

Powered by Google App Engine
This is Rietveld 408576698