Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2993003002: Avoid graph extending outside the drawing area. (Closed)

Created:
3 years, 4 months ago by cbernaschina
Modified:
3 years, 4 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Avoid graph extending outside the drawing area. In the memory-dashboard page of Observatory the graph is drawn in the wrong way if the communication with the device is slow. Related https://github.com/google/charted/issues/219 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/82e9557aa78cc1ff43ea60bc443758558bbe4d99

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M runtime/observatory/lib/src/elements/memory/graph.dart View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
cbernaschina
3 years, 4 months ago (2017-08-03 23:58:47 UTC) #2
siva
lgtm
3 years, 4 months ago (2017-08-04 00:00:53 UTC) #3
cbernaschina
3 years, 4 months ago (2017-08-04 00:05:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
82e9557aa78cc1ff43ea60bc443758558bbe4d99 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698