Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart

Issue 2992993002: Revert "Work-around for missing mixin-application charOffset" (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
index 181d22ca1c575294f7a71091beb59270dd3313c4..d8df4f86fc88338d1476241da82eef9b8281e558 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart
@@ -290,10 +290,6 @@ class KernelLibraryBuilder
int unresolvedCount = 0;
Map<String, TypeBuilder> freeTypes = <String, TypeBuilder>{};
- // TODO(30316): Use correct locations of mixin applications
- // (e.g. identifiers for mixed-in classes).
- if (charOffset == -1) charOffset = type.charOffset;
-
if (name == null || type.mixins.length != 1) {
TypeBuilder last = type.mixins.last;
@@ -423,8 +419,8 @@ class KernelLibraryBuilder
checkArguments(mixin);
supertype = applyMixin(supertype, mixin, signature,
isSyntheticMixinImplementation: true,
- typeVariables: new List<TypeVariableBuilder>.from(variables.values),
- charOffset: charOffset);
+ typeVariables:
+ new List<TypeVariableBuilder>.from(variables.values));
}
KernelNamedTypeBuilder mixin = type.mixins.last;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698