Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 2992923002: These changes are suspects in the recent bot flakiness. (Closed)

Created:
3 years, 4 months ago by danunez
Modified:
3 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

These changes are suspects in the recent bot flakiness. Revert "Changes new space allocation from simple bump pointer allocation from" This reverts commit e6e378bb6eb5ba90f890399a889b8daad8418c45. Revert "Fixes bug in calculation of memory used by new space" This reverts commit 044f818f014b4879504ad20f2113c7df03f99c79. BUG= Committed: https://github.com/dart-lang/sdk/commit/bb6203dadefc1bbe613b92ba25a91da06d55c194

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -148 lines) Patch
M runtime/vm/heap.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/heap.cc View 2 chunks +9 lines, -58 lines 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +7 lines, -10 lines 0 comments Download
M runtime/vm/scavenger.h View 7 chunks +7 lines, -27 lines 0 comments Download
M runtime/vm/scavenger.cc View 7 chunks +18 lines, -48 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danunez
3 years, 4 months ago (2017-08-02 22:28:28 UTC) #1
danunez
Committed patchset #1 (id:1) manually as bb6203dadefc1bbe613b92ba25a91da06d55c194 (presubmit successful).
3 years, 4 months ago (2017-08-02 22:45:14 UTC) #3
rmacnak
3 years, 4 months ago (2017-08-02 22:52:16 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698