Reapply "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, …

Reapply "[vm] Don't enable the profiler by default. Enable the profiler at startup with --observe, or later through Observatory."

Ensure we still start NativeSymbolResolver even if the profiler is off, since it is also used name weak handler finalizer functions and to produce stack traces for crashes.

R=bkonyi@google.com

Committed: https://github.com/dart-lang/sdk/commit/f8e47a9e26c9ee44f431ed20d4507d98acbc257d

[rmacnak, 2017-08-02 21:07:58]

rmacnak@google.com changed reviewers:
+ bkonyi@google.com

[rmacnak, 2017-08-08 20:32:40]

ping

[bkonyi, 2017-08-08 23:55:11]

Not LGTM. Here's the test failure:

=== Failure summary:


FAILED: none-vm debug_x64 vm/cc/Service_PersistentHandles
Expected: Pass
Actual: Crash
CommandOutput[run_vm_unittest]:

stdout:
Running test: Service_PersistentHandles


stderr:
c:\users\bkonyi\dart-sdk\sdk\runtime\vm\lockers.h: 50: error: expected: mutex !=
NULL
Dumping native stack trace for thread 40a8
c:\users\bkonyi\dart-sdk\sdk\runtime\vm\lockers.h: 50: error: expected: mutex !=
NULL
Aborting re-entrant request for stack trace.


Command[run_vm_unittest]: set DART_CONFIGURATION=DebugX64 &
out\DebugX64\run_vm_tests --ignore-unrecognized-flags Service_PersistentHandles
Took 0:00:00.105586

Short reproduction command (experimental):
    python tools/test.py vm/cc/Service_PersistentHandles



===
=== 1 test failed
===

[00:37 | 100% | + 1005 | -    1]


I'll follow up with more information when I can figure out how to get it...

[rmacnak, 2017-08-09 01:27:00]

On 2017/08/08 23:55:11, bkonyi wrote:
> Not LGTM. Here's the test failure:
> 
> === Failure summary:
> 
> 
> FAILED: none-vm debug_x64 vm/cc/Service_PersistentHandles
> Expected: Pass
> Actual: Crash
> CommandOutput[run_vm_unittest]:
> 
> stdout:
> Running test: Service_PersistentHandles
> 
> 
> stderr:
> c:\users\bkonyi\dart-sdk\sdk\runtime\vm\lockers.h: 50: error: expected: mutex
!=
> NULL
> Dumping native stack trace for thread 40a8
> c:\users\bkonyi\dart-sdk\sdk\runtime\vm\lockers.h: 50: error: expected: mutex
!=
> NULL
> Aborting re-entrant request for stack trace.
> 
> 
> Command[run_vm_unittest]: set DART_CONFIGURATION=DebugX64 &
> out\DebugX64\run_vm_tests --ignore-unrecognized-flags
Service_PersistentHandles
> Took 0:00:00.105586
> 
> Short reproduction command (experimental):
>     python tools/test.py vm/cc/Service_PersistentHandles
> 
> 
> 
> ===
> === 1 test failed
> ===
> 
> [00:37 | 100% | + 1005 | -    1]
> 
> 
> I'll follow up with more information when I can figure out how to get it...

We figured out it was because NativeSymbolResolver needs to be initialized even
if the profiler is off. It is used to name the finalizers attached to weak
handles or during crash dumps. It only affects Windows because Linux/Mac have
no-op NativeSymbolResolver::InitOnce()

[rmacnak, 2017-08-09 01:36:36]

Description was changed from

==========
Reapply "[vm] Don't enable the profiler by default. Enable the profiler at
startup with --observe, or later through Observatory."

Remove profiler shutdown change.
==========

to

==========
Reapply "[vm] Don't enable the profiler by default. Enable the profiler at
startup with --observe, or later through Observatory."

Ensure we still start NativeSymbolResolver even if the profiler is off, since it
is also used name weak handler finalizer functions and to produce stack traces
for crashes.
==========

[rmacnak, 2017-08-09 17:00:36]

Adjusted the startup logic to initialize symbol lookup even if the profiler is
off.

[bkonyi, 2017-08-09 17:04:42]

LGTM

[rmacnak, 2017-08-09 18:21:02]

Description was changed from

==========
Reapply "[vm] Don't enable the profiler by default. Enable the profiler at
startup with --observe, or later through Observatory."

Ensure we still start NativeSymbolResolver even if the profiler is off, since it
is also used name weak handler finalizer functions and to produce stack traces
for crashes.
==========

to

==========
Reapply "[vm] Don't enable the profiler by default. Enable the profiler at
startup with --observe, or later through Observatory."

Ensure we still start NativeSymbolResolver even if the profiler is off, since it
is also used name weak handler finalizer functions and to produce stack traces
for crashes.

R=bkonyi@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f8e47a9e26c9ee44f431ed20d4507d98acbc257d
==========

[rmacnak, 2017-08-09 18:21:05]

Committed patchset #3 (id:40001) manually as
f8e47a9e26c9ee44f431ed20d4507d98acbc257d (presubmit successful).