Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2992843002: Add more documentation for plugins (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
devoncarew, mfairhurst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+309 lines, -8 lines) Patch
M pkg/analyzer_plugin/doc/tutorial/assists.md View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer_plugin/doc/tutorial/completion.md View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer_plugin/doc/tutorial/fixes.md View 1 chunk +1 line, -1 line 0 comments Download
A pkg/analyzer_plugin/doc/tutorial/introduction.md View 1 chunk +218 lines, -0 lines 2 comments Download
A pkg/analyzer_plugin/doc/tutorial/navigation.md View 1 chunk +79 lines, -0 lines 0 comments Download
M pkg/analyzer_plugin/doc/tutorial/tutorial.md View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
Also fixes Mike's comments from a previous CL.
3 years, 4 months ago (2017-08-01 21:15:17 UTC) #2
devoncarew
lgtm lgtm! You might consider renaming tutorial.md to readme.md - some system look for that ...
3 years, 4 months ago (2017-08-01 22:19:16 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2992843002/diff/1/pkg/analyzer_plugin/doc/tutorial/introduction.md File pkg/analyzer_plugin/doc/tutorial/introduction.md (right): https://codereview.chromium.org/2992843002/diff/1/pkg/analyzer_plugin/doc/tutorial/introduction.md#newcode17 pkg/analyzer_plugin/doc/tutorial/introduction.md:17: them in the same VM as the analysis server ...
3 years, 4 months ago (2017-08-02 14:45:16 UTC) #4
Brian Wilkerson
3 years, 4 months ago (2017-08-02 14:45:48 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4e1644f12affdcdb2de71f5fec0f2acf0b243578 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698