Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2992833002: Migrated test block 15 to Dart 2.0. (Closed)

Created:
3 years, 4 months ago by bkonyi
Modified:
3 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Migrated test block 15 to Dart 2.0. list_unmodifiable_test required some modifications so callbacks matched the correct types. list_unmodifiable_test and list_test also needed to be disabled on dartdevc due to some issue with List<int> not mapping to JSArray. BUG= R=rnystrom@google.com Committed: https://github.com/dart-lang/sdk/commit/ce197702e46916ca9c7f1a0c4377b63a967a29ab

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2019 lines) Patch
M tests/corelib/corelib.status View 3 chunks +0 lines, -7 lines 0 comments Download
D tests/corelib/list_test.dart View 1 chunk +0 lines, -633 lines 0 comments Download
D tests/corelib/list_to_string2_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib/list_to_string_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib/list_unmodifiable_test.dart View 1 chunk +0 lines, -304 lines 0 comments Download
M tests/corelib_2/corelib_2.status View 4 chunks +12 lines, -0 lines 0 comments Download
A + tests/corelib_2/list_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_to_string2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_to_string_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/corelib_2/list_unmodifiable_test.dart View 1 chunk +17 lines, -17 lines 1 comment Download
M tests/corelib_strong/corelib_strong.status View 1 chunk +0 lines, -2 lines 0 comments Download
D tests/corelib_strong/list_test.dart View 1 chunk +0 lines, -633 lines 0 comments Download
D tests/corelib_strong/list_to_string2_test.dart View 1 chunk +0 lines, -32 lines 0 comments Download
D tests/corelib_strong/list_to_string_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/corelib_strong/list_unmodifiable_test.dart View 1 chunk +0 lines, -300 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
bkonyi
3 years, 4 months ago (2017-08-01 20:13:28 UTC) #2
Bob Nystrom
LGTM! https://codereview.chromium.org/2992833002/diff/1/tests/corelib_2/list_unmodifiable_test.dart File tests/corelib_2/list_unmodifiable_test.dart (right): https://codereview.chromium.org/2992833002/diff/1/tests/corelib_2/list_unmodifiable_test.dart#newcode216 tests/corelib_2/list_unmodifiable_test.dart:216: Can you type these more precisely? If not, ...
3 years, 4 months ago (2017-08-02 20:50:47 UTC) #3
bkonyi
3 years, 4 months ago (2017-08-03 18:12:32 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ce197702e46916ca9c7f1a0c4377b63a967a29ab.

Powered by Google App Engine
This is Rietveld 408576698