Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2992803002: [Fuchsia] Fix Process exit code handler (Closed)

Created:
3 years, 4 months ago by zra
Modified:
3 years, 4 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[Fuchsia] Fix Process exit code handler There was a bug in the logic for maintaining the array of handles to wait on. Using the ports API instead removes the need to maintain an array of handles. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/e8eebba056a15594fa37aaa5051f968e8d6f7d64

Patch Set 1 #

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -182 lines) Patch
M runtime/bin/process_fuchsia.cc View 1 9 chunks +70 lines, -182 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 4 months ago (2017-08-01 17:51:51 UTC) #2
rmacnak
LGTM
3 years, 4 months ago (2017-08-01 19:56:07 UTC) #3
zra
3 years, 4 months ago (2017-08-01 20:57:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e8eebba056a15594fa37aaa5051f968e8d6f7d64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698