Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart

Issue 2992773002: Kernel driver: pass options and use it for its compiler context (Closed)
Patch Set: v1 Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart
diff --git a/pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart b/pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart
index 6322b34e07b68ecaeae801f378862b5984dda77f..c5d976027032fa73ea36adf4878edf736f423ab4 100644
--- a/pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart
+++ b/pkg/front_end/example/incremental_reload/compiler_with_invalidation.dart
@@ -34,6 +34,10 @@ Future<IncrementalCompiler> createIncrementalCompiler(String entry,
..packagesFileUri = Uri.base.resolve('.packages')
..strongMode = false
..dartLibraries = loadDartLibraries(sdkRoot)
+ // Note: we do not report error on the console because the incremental
+ // compiler is an ongoing background service that shouldn't polute stdout.
+ // TODO(sigmund): do something with the errors.
+ ..onError = (_) {}
..byteStore =
persistent ? new FileByteStore(tmpDir.path) : new MemoryByteStore();
return IncrementalCompiler.create(options, entryUri);

Powered by Google App Engine
This is Rietveld 408576698