Add boxed fields in closure classes.

Add boxed fields in closure classes.


BUG=
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/c91ce4dcb3ed494a23bc861487ffce45c68a75c6

[Emily Fortuna, 2017-07-31 22:55:59]

efortuna@google.com changed reviewers:
+ johnniwinther@google.com, sra@google.com

[Emily Fortuna, 2017-07-31 22:56:06]

Patchset #2 (id:20001) has been deleted

[Emily Fortuna, 2017-07-31 22:56:12]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-08-01 00:54:37]

On 2017/07/31 22:56:00, Emily Fortuna wrote:

ps. Johnni, if you want to see what I'm hitting now in the backend, you can
patch this CL in, but the error looks something like this: 
The compiler crashed: UnimplementedError:
KernelClosedWorldMixin.hasConcreteMatch
#0      ClosedWorldBase&KernelClosedWorldMixin.hasConcreteMatch
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/kernel/element_map_impl.dart:1574:5)
#1      ClosedWorldBase.needsNoSuchMethod.subclassesNeedNoSuchMethod
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:839:11)
#2      ClosedWorldBase.needsNoSuchMethod
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:865:40)
#3      FlatTypeMask.needsNoSuchMethodHandling
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/types/flat_type_mask.dart:540:24)
#4      SelectorMask.needsNoSuchMethodHandling
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/universe/function_set.dart:124:23)
#5      FunctionSetNode.query
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/universe/function_set.dart:228:22)
#6      FunctionSet.query
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/universe/function_set.dart:83:19)
#7      FunctionSet.filter
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/universe/function_set.dart:46:12)
#8      ClosedWorldBase.locateMembers
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:1036:26)
#9      FlatTypeMask.locateSingleElement
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/types/flat_type_mask.dart:545:50)
#10     ClosedWorldBase.locateSingleElement
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:1053:17)
#11     ClosedWorldBase.locateSingleField
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:1047:27)
#12     SsaInstructionSimplifier.findConcreteFieldForDynamicAccess
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:899:25)
#13     SsaInstructionSimplifier.visitInvokeDynamicGetter
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:983:9)
#14     HInvokeDynamicGetter.accept
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/nodes.dart:1757:39)
#15     SsaInstructionSimplifier.visitBasicBlock
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:211:46)
#16     HGraphVisitor.visitDominatorTree
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/nodes.dart:133:9)
#17     SsaInstructionSimplifier.visitGraph
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:204:5)
#18     SsaOptimizerTask.optimize.runPhase.<anonymous closure>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:59:46)
#19     CompilerTask.measureSubtask
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/common/tasks.dart:176:35)
#20     SsaOptimizerTask.optimize.runPhase
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:59:7)
#21     List.forEach (dart:core-patch/growable_array.dart:267)
#22     SsaOptimizerTask.optimize.<anonymous closure>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:115:14)
#23     CompilerTask.measure
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/common/tasks.dart:63:44)
#24     SsaOptimizerTask.optimize
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:69:5)
#25     SsaFunctionCompiler.compile
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/ssa.dart:45:15)
#26     JavaScriptBackend.codegen
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/js_backend/backend.dart:890:43)
#27     KernelCodegenWorkItem.run
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart:77:21)

[Johnni Winther, 2017-08-01 07:10:19]

On 2017/08/01 00:54:37, Emily Fortuna wrote:
> On 2017/07/31 22:56:00, Emily Fortuna wrote:
> 
> ps. Johnni, if you want to see what I'm hitting now in the backend, you can
> patch this CL in, but the error looks something like this: 
> The compiler crashed: UnimplementedError:
> KernelClosedWorldMixin.hasConcreteMatch
> #0      ClosedWorldBase&KernelClosedWorldMixin.hasConcreteMatch
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/kernel/element_map_impl.dart:1574:5)
> #1      ClosedWorldBase.needsNoSuchMethod.subclassesNeedNoSuchMethod
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:839:11)
> #2      ClosedWorldBase.needsNoSuchMethod
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:865:40)
> #3      FlatTypeMask.needsNoSuchMethodHandling
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/types/flat_type_mask.dart:540:24)
> #4      SelectorMask.needsNoSuchMethodHandling
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/universe/function_set.dart:124:23)
> #5      FunctionSetNode.query
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/universe/function_set.dart:228:22)
> #6      FunctionSet.query
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/universe/function_set.dart:83:19)
> #7      FunctionSet.filter
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/universe/function_set.dart:46:12)
> #8      ClosedWorldBase.locateMembers
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:1036:26)
> #9      FlatTypeMask.locateSingleElement
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/types/flat_type_mask.dart:545:50)
> #10     ClosedWorldBase.locateSingleElement
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:1053:17)
> #11     ClosedWorldBase.locateSingleField
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/world.dart:1047:27)
> #12     SsaInstructionSimplifier.findConcreteFieldForDynamicAccess
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:899:25)
> #13     SsaInstructionSimplifier.visitInvokeDynamicGetter
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:983:9)
> #14     HInvokeDynamicGetter.accept
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/nodes.dart:1757:39)
> #15     SsaInstructionSimplifier.visitBasicBlock
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:211:46)
> #16     HGraphVisitor.visitDominatorTree
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/nodes.dart:133:9)
> #17     SsaInstructionSimplifier.visitGraph
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:204:5)
> #18     SsaOptimizerTask.optimize.runPhase.<anonymous closure>
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:59:46)
> #19     CompilerTask.measureSubtask
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/common/tasks.dart:176:35)
> #20     SsaOptimizerTask.optimize.runPhase
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:59:7)
> #21     List.forEach (dart:core-patch/growable_array.dart:267)
> #22     SsaOptimizerTask.optimize.<anonymous closure>
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:115:14)
> #23     CompilerTask.measure
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/common/tasks.dart:63:44)
> #24     SsaOptimizerTask.optimize
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/optimize.dart:69:5)
> #25     SsaFunctionCompiler.compile
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/ssa/ssa.dart:45:15)
> #26     JavaScriptBackend.codegen
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/js_backend/backend.dart:890:43)
> #27     KernelCodegenWorkItem.run
>
(file:///usr/local/google/home/efortuna/dart/sdk/pkg/compiler/lib/src/kernel/kernel_backend_strategy.dart:77:21)

I have a fix for this.

[Johnni Winther, 2017-08-01 09:09:10]

lgtm

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_model/closure_visitors.dart (right):

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/closure_visitors.dart:92:
_getMemberContext(_executableContext)),
The member context is not needed. See comment in [_constructClosureFields].

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:2056:
localsMap.getLocalVariable(box.executableContext),
The `Local.executableContext` is actually not needed after closure translation.
I'll remove it when you're done with the closure conversion.

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:2057:
getMember(box.memberContext)),
The member is always the member passed to [constructClosureClass], just use this
here and avoid the need for memberContext computation.

[Emily Fortuna, 2017-08-01 18:27:39]

Description was changed from

==========
Add boxed fields in closure classes.


BUG=
==========

to

==========
Add boxed fields in closure classes.


BUG=
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c91ce4dcb3ed494a23bc861487ffce45c68a75c6
==========

[Emily Fortuna, 2017-08-01 18:27:43]

Committed patchset #2 (id:60001) manually as
c91ce4dcb3ed494a23bc861487ffce45c68a75c6 (presubmit successful).

[Emily Fortuna, 2017-08-01 19:30:06]

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_model/closure_visitors.dart (right):

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_model/closure_visitors.dart:92:
_getMemberContext(_executableContext)),
On 2017/08/01 09:09:10, Johnni Winther wrote:
> The member context is not needed. See comment in [_constructClosureFields].

got it.

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/ke...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:2056:
localsMap.getLocalVariable(box.executableContext),
On 2017/08/01 09:09:10, Johnni Winther wrote:
> The `Local.executableContext` is actually not needed after closure
translation.
> I'll remove it when you're done with the closure conversion.

Acknowledged.

https://codereview.chromium.org/2992763002/diff/60001/pkg/compiler/lib/src/ke...
pkg/compiler/lib/src/kernel/element_map_impl.dart:2057:
getMember(box.memberContext)),
On 2017/08/01 09:09:10, Johnni Winther wrote:
> The member is always the member passed to [constructClosureClass], just use
this
> here and avoid the need for memberContext computation.

Done.