runtime/vm/scavenger.h - Issue 2992753002: Prepares allocation for proper sync with mutator and bg threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/scavenger.h

Issue 2992753002: Prepares allocation for proper sync with mutator and bg threads. (Closed)

Patch Set: Adds thread locking to functions that iterate over threads Created 3 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/scavenger.h

diff --git a/runtime/vm/scavenger.h b/runtime/vm/scavenger.h

index 0721fe2f91615dbc0fc9701028de5d05aec93ef9..df29bd9b11371b9126634b3022b40b468b73a92e 100644

--- a/runtime/vm/scavenger.h

+++ b/runtime/vm/scavenger.h

@@ -234,8 +234,10 @@ class Scavenger {

void AllocateExternal(intptr_t size);

void FreeExternal(intptr_t size);

- uword FlushTLS() const;

- void UnflushTLS(uword value) const;

+ uword FindTopOfSpace(Isolate* isolate) const;

+ void MakeALLTLABsIterable(Isolate* isolate) const;

+ void FlushTLS() const;

+ void AbandonAllTLABs(Isolate* isolate);

uword FirstObjectStart() const { return to_->start() | object_alignment_; }

private:

@@ -334,6 +336,7 @@ class Scavenger {

bool failed_to_promote_;

+ Mutex* space_lock_;

friend class ScavengerVisitor;

friend class ScavengerWeakVisitor;