Prepares allocation for proper sync with mutator and bg threads.

runtime/vm/heap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/heap.h"
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/flags.h"
 #include "vm/isolate.h"
@@ skipping 40 matching lines @@
 Heap::~Heap() {
   delete barrier_;
   delete barrier_done_;
 
   for (int sel = 0; sel < kNumWeakSelectors; sel++) {
     delete new_weak_tables_[sel];
     delete old_weak_tables_[sel];
   }
 }
 
-void Heap::FillRemainingTLAB(Thread* thread) {
+void Heap::MakeTLABIterable(Thread* thread) {
   uword start = thread->top();
   uword end = thread->end();
   ASSERT(end >= start);
   intptr_t size = end - start;
   ASSERT(Utils::IsAligned(size, kObjectAlignment));
   if (size >= kObjectAlignment) {
     FreeListElement::AsElement(start, size);
     ASSERT(RawObject::FromAddr(start)->Size() == size);
-    ASSERT((start + size) == new_space_.top());
   }
 }
 
 void Heap::AbandonRemainingTLAB(Thread* thread) {
-  FillRemainingTLAB(thread);
+  MakeTLABIterable(thread);
   thread->set_top(0);
   thread->set_end(0);
 }
 
 intptr_t Heap::CalculateTLABSize() {
   intptr_t size = new_space_.end() - new_space_.top();
   return Utils::RoundDown(size, kObjectAlignment);
 }
 
 uword Heap::AllocateNew(intptr_t size) {
@@ skipping 19 matching lines @@
       ASSERT(addr != 0);
       return addr;
     }
   }
 
   ASSERT(!thread->HasActiveTLAB());
 
   // This call to CollectGarbage might end up "reusing" a collection spawned
   // from a different thread and will be racing to allocate the requested
   // memory with other threads being released after the collection.
+  // TODO(danunez): Ensure that once we start collecting garbage, everything
+  // stops allocating.
+  // Safepoint should be dealing with this, but we need to make sure somehow.
   CollectGarbage(kNew);
   tlab_size = CalculateTLABSize();
   uword tlab_top = new_space_.TryAllocateNewTLAB(thread, tlab_size);
   if (tlab_top != 0) {
     addr = new_space_.TryAllocateInTLAB(thread, size);
     // It is possible a GC doesn't clear enough space.
     // In that case, we must fall through and allocate into old space.
     if (addr != 0) {
       return addr;
     }
@@ skipping 498 matching lines @@
 
 bool Heap::VerifyGC(MarkExpectation mark_expectation) const {
   StackZone stack_zone(Thread::Current());
 
   // Change the new space's top_ with the more up-to-date thread's view of top_
   new_space_.MakeNewSpaceIterable();
 
   ObjectSet* allocated_set =
       CreateAllocatedObjectSet(stack_zone.GetZone(), mark_expectation);
   VerifyPointersVisitor visitor(isolate(), allocated_set);
+  // TODO(danunez): Need to lock and unlock for new space here.

[rmacnak, 2017/08/10 18:37:06]

This function should already be always running during a safepoint.

[danunez, 2017/08/10 20:36:46]

Done.

   VisitObjectPointers(&visitor);
 
   // Only returning a value so that Heap::Validate can be called from an ASSERT.
   return true;
 }
 
 void Heap::PrintSizes() const {
   OS::PrintErr(
       "New space (%" Pd64 "k of %" Pd64
       "k) "
@@ skipping 256 matching lines @@
     : StackResource(thread) {
   Dart::vm_isolate()->heap()->WriteProtect(false);
 }
 
 WritableVMIsolateScope::~WritableVMIsolateScope() {
   ASSERT(Dart::vm_isolate()->heap()->UsedInWords(Heap::kNew) == 0);
   Dart::vm_isolate()->heap()->WriteProtect(true);
 }
 
 }  // namespace dart