Prepares allocation for proper sync with mutator and bg threads.

runtime/vm/heap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/heap.h"
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/flags.h"
 #include "vm/isolate.h"
@@ skipping 39 matching lines @@
 Heap::~Heap() {
   delete barrier_;
   delete barrier_done_;
 
   for (int sel = 0; sel < kNumWeakSelectors; sel++) {
     delete new_weak_tables_[sel];
     delete old_weak_tables_[sel];
   }
 }
 
-void Heap::AbandonRemainingTLAB(Thread* thread) {
+void Heap::FillRemainingTLAB(Thread* thread) {
   uword start = thread->top();
   uword end = thread->end();
   ASSERT(end >= start);
   intptr_t size = end - start;
   if (end == new_space_.end()) {
     size = 0;
   }
   ASSERT(Utils::IsAligned(size, kObjectAlignment));
   if (size >= kObjectAlignment) {
     FreeListElement::AsElement(start, size);
     ASSERT(RawObject::FromAddr(start)->Size() == size);
-    ASSERT((start + size) == new_space_.top());
   }
+}
+
+void Heap::AbandonRemainingTLAB(Thread* thread) {
+  FillRemainingTLAB(thread);
   thread->set_top(0);
   thread->set_end(0);
 }
 
 intptr_t Heap::CalculateTLABSize() {
   intptr_t size = new_space_.end() - new_space_.top();
   return Utils::RoundDown(size, kObjectAlignment);
 }
 
 uword Heap::AllocateNew(intptr_t size) {
   ASSERT(Thread::Current()->no_safepoint_scope_depth() == 0);
   // Currently, only the Dart thread may allocate in new space.
   isolate()->AssertCurrentThreadIsMutator();
+  ASSERT(Thread::Current()->IsMutatorThread());

[rmacnak, 2017/08/01 21:51:25]

Isn't this the same as the line above?

[danunez, 2017/08/01 23:25:34]

Yes it is. I will remove it.

   Thread* thread = Thread::Current();
   uword addr = new_space_.TryAllocateInTLAB(thread, size);
   if (addr != 0) {
     return addr;
   }
 
   intptr_t tlab_size = CalculateTLABSize();
   if ((tlab_size > 0) && (size > tlab_size)) {
     return AllocateOld(size, HeapPage::kData);
   }
 
   AbandonRemainingTLAB(thread);
+
+  // TODO(danunez): Lock for new space here
   if (tlab_size > 0) {
     uword tlab_top = new_space_.TryAllocateNewTLAB(thread, tlab_size);
     if (tlab_top != 0) {
       addr = new_space_.TryAllocateInTLAB(thread, size);
       ASSERT(addr != 0);
+      // TODO(danunez): Unlock for new space here
       return addr;
     }
   }
 
   ASSERT(!thread->HasActiveTLAB());
 
   // This call to CollectGarbage might end up "reusing" a collection spawned
   // from a different thread and will be racing to allocate the requested
   // memory with other threads being released after the collection.
+
+  // TODO(danunez): Ensure that once we start collecting garbage, everything
+  // stops allocating.
+  // Safepoint should be dealing with this, but we need to make sure somehow.
   CollectGarbage(kNew);
   tlab_size = CalculateTLABSize();
   uword tlab_top = new_space_.TryAllocateNewTLAB(thread, tlab_size);
+
+  // TODO(danunez): Unlock for new space here. Regardless of the outcome, we
+  // don't need the new space.
   if (tlab_top != 0) {
     addr = new_space_.TryAllocateInTLAB(thread, size);
     // It is possible a GC doesn't clear enough space.
     // In that case, we must fall through and allocate into old space.
     if (addr != 0) {
       return addr;
     }
   }
   return AllocateOld(size, HeapPage::kData);
 }
@@ skipping 752 matching lines @@
     : StackResource(thread) {
   Dart::vm_isolate()->heap()->WriteProtect(false);
 }
 
 WritableVMIsolateScope::~WritableVMIsolateScope() {
   ASSERT(Dart::vm_isolate()->heap()->UsedInWords(Heap::kNew) == 0);
   Dart::vm_isolate()->heap()->WriteProtect(true);
 }
 
 }  // namespace dart