Issue 2992733003: Revert "[vm] Revise Dart_IntegerToHexCString to avoid dependency on Bigint"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2992733003: Revert "[vm] Revise Dart_IntegerToHexCString to avoid dependency on Bigint" (Closed)

Created:
3 years, 4 months ago by alexmarkov

Modified:
3 years, 4 months ago

Reviewers:
zra, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "[vm] Revise Dart_IntegerToHexCString to avoid dependency on Bigint" This reverts commit 3d4838fc70a5439437a5ceb4247551315c294477 as it fails to compile on Windows. Committed: https://github.com/dart-lang/sdk/commit/caffcd87021acc892a257eb1b4962a5b002c6e03

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -83 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	3 chunks	+14 lines, -65 lines	0 comments	Download
M	runtime/vm/object.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Total messages: 4 (2 generated)

alexmarkov

3 years, 4 months ago (2017-08-01 16:08:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
caffcd87021acc892a257eb1b4962a5b002c6e03 (presubmit successful).