Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 2992633004: front_end analyzer dev dependency. (Closed)

Created:
3 years, 4 months ago by pquitslund
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

front_end analyzer dev dependency. To satisfy dependencies, for example, in `tool/perf.dart`. Duplicate of https://codereview.chromium.org/2985143002/ (which fails to land). R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/7370c8f7499b69c6c4aca7a7d36aad65bf1ce3c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M pkg/front_end/pubspec.yaml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
pquitslund
3 years, 4 months ago (2017-07-28 13:35:28 UTC) #4
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-07-28 13:37:34 UTC) #5
pquitslund
3 years, 4 months ago (2017-07-28 13:38:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7370c8f7499b69c6c4aca7a7d36aad65bf1ce3c8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698