[infra] Begin removing gyp

[infra] Begin removing gyp

This CL begins removing gyp from Dart's tree.

Removing gyp will go in three stages:
1. Remove unused .gyp and .gypi files.
2. Translate *_sources.gypi files to *_sources.gni files
3. Remove //third_party/gyp from DEPS

This CL is stage 1.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/0394d3a0cf71be64b113f74a18289d2be210f5a0

[zra, 2017-07-28 20:35:07]

Description was changed from

==========
Begin removing gyp
==========

to

==========
[infra] Begin removing gyp

This CL begins removing gyp from Dart's tree.

Removing gyp will go in three stages:
1. Remove unused .gyp and .gypi files.
2. Translate *_sources.gypi files to *_sources.gni files
3. Remove //third_party/gyp from DEPS

This CL is stage 1.
==========

[zra, 2017-07-28 21:17:49]

zra@google.com changed reviewers:
+ asiva@google.com, whesse@google.com

[rmacnak, 2017-07-28 21:27:58]

rmacnak@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-07-28 21:28:00]

\O/

[zra, 2017-08-04 15:53:16]

ping

[siva, 2017-08-04 16:48:19]

asiva@google.com changed reviewers:
+ keertip@google.com

[siva, 2017-08-04 16:48:20]

+keerti

So she is aware we are dropping support for GYP, I think she migrates build
changes to google3 by tracking changes to the '.gypi' and '.gyp' files.

[keertip, 2017-08-04 16:53:22]

https://codereview.chromium.org/2992593002/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (left):

https://codereview.chromium.org/2992593002/diff/1/runtime/bin/bin.gypi#oldcode69
runtime/bin/bin.gypi:69: 'target_name': 'generate_io_cc_file',
Zach, we have translated these into genrules in the BUILD file in google3. What
would I now track for updates to these genrules?

[keertip, 2017-08-04 16:58:02]

https://codereview.chromium.org/2992593002/diff/1/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (left):

https://codereview.chromium.org/2992593002/diff/1/runtime/vm/vm.gypi#oldcode256
runtime/vm/vm.gypi:256: '<(async_cc_file)',
And we have filegroups for these too, and genrules for the generated files in
this gyp too.

[zra, 2017-08-04 16:58:03]

On 2017/08/04 16:53:22, keertip wrote:
> https://codereview.chromium.org/2992593002/diff/1/runtime/bin/bin.gypi
> File runtime/bin/bin.gypi (left):
> 
>
https://codereview.chromium.org/2992593002/diff/1/runtime/bin/bin.gypi#oldcode69
> runtime/bin/bin.gypi:69: 'target_name': 'generate_io_cc_file',
> Zach, we have translated these into genrules in the BUILD file in google3.
What
> would I now track for updates to these genrules?

You will need to track changes to BUILD.gn files that exist nearly 1:1 for the
removed .gyp(i) files. For example //runtime/bin/bin.gypi ->
//runtime/bin/BUILD.gn.

[zra, 2017-08-04 17:01:54]

https://codereview.chromium.org/2992593002/diff/1/runtime/bin/bin.gypi
File runtime/bin/bin.gypi (left):

https://codereview.chromium.org/2992593002/diff/1/runtime/bin/bin.gypi#oldcode69
runtime/bin/bin.gypi:69: 'target_name': 'generate_io_cc_file',
On 2017/08/04 16:53:22, keertip wrote:
> Zach, we have translated these into genrules in the BUILD file in google3.
What
> would I now track for updates to these genrules?

Sorry, misunderstood your question at first. There is a template here:

https://github.com/dart-lang/sdk/blob/master/runtime/bin/BUILD.gn#L44

For the invocations of gen_library_src_paths.py

https://codereview.chromium.org/2992593002/diff/1/runtime/vm/vm.gypi
File runtime/vm/vm.gypi (left):

https://codereview.chromium.org/2992593002/diff/1/runtime/vm/vm.gypi#oldcode256
runtime/vm/vm.gypi:256: '<(async_cc_file)',
On 2017/08/04 16:58:02, keertip wrote:
> And we have filegroups for these too, and genrules for the generated files in
> this gyp too.

These are covered by the template here:

https://github.com/dart-lang/sdk/blob/master/runtime/vm/BUILD.gn#L229

[siva, 2017-08-04 20:42:42]

lgtm

[zra, 2017-08-05 05:19:47]

Description was changed from

==========
[infra] Begin removing gyp

This CL begins removing gyp from Dart's tree.

Removing gyp will go in three stages:
1. Remove unused .gyp and .gypi files.
2. Translate *_sources.gypi files to *_sources.gni files
3. Remove //third_party/gyp from DEPS

This CL is stage 1.
==========

to

==========
[infra] Begin removing gyp

This CL begins removing gyp from Dart's tree.

Removing gyp will go in three stages:
1. Remove unused .gyp and .gypi files.
2. Translate *_sources.gypi files to *_sources.gni files
3. Remove //third_party/gyp from DEPS

This CL is stage 1.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/0394d3a0cf71be64b113f74a18289d2be210f5a0
==========

[zra, 2017-08-05 05:19:52]

Committed patchset #1 (id:1) manually as
0394d3a0cf71be64b113f74a18289d2be210f5a0 (presubmit successful).