Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2992573002: Specialize imported_withPrefix tests for resynthesizing from Kernel. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Specialize imported_withPrefix tests for resynthesizing from Kernel. We don't get back AST with prefixes, so it would require additional work to find them. We does need them though, as long as resolution is correct. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/f813e21f125809e19ec6155e6e9221fdc1573ac4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -36 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 7 chunks +59 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-07-26 19:18:59 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-07-26 19:37:27 UTC) #2
scheglov
3 years, 4 months ago (2017-07-26 22:02:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f813e21f125809e19ec6155e6e9221fdc1573ac4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698