[vm] Update runtime/vm/stub_code_<arch>_test to avoid using Bigints

[vm] Update runtime/vm/stub_code_<arch>_test to avoid using Bigints

In preparation for limiting Dart integers to 64 bits, test for stub
code generation is updated to avoid using Bigints.
Instead of calling kBigintCompareRuntimeEntry leaf runtime entry,
this test now calls kCaseInsensitiveCompareUC16RuntimeEntry.

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed: https://github.com/dart-lang/sdk/commit/da654d9a5f387e54d7a991df7d3ed19b5230d8cf

[alexmarkov, 2017-07-25 23:10:18]

alexmarkov@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com, zra@google.com

[zra, 2017-07-26 16:12:23]

lgtm w/ cleanup suggestion.

https://codereview.chromium.org/2992483002/diff/1/runtime/vm/stub_code_arm64_...
File runtime/vm/stub_code_arm64_test.cc (right):

https://codereview.chromium.org/2992483002/diff/1/runtime/vm/stub_code_arm64_...
runtime/vm/stub_code_arm64_test.cc:97: Assembler _assembler_;
It seems like giving this a weird name might be unnecessary. Can this be changed
to _assembler_. Also above in TEST_CASE(CallRuntimeStubCode)?

[alexmarkov, 2017-07-26 20:14:14]

https://codereview.chromium.org/2992483002/diff/1/runtime/vm/stub_code_arm64_...
File runtime/vm/stub_code_arm64_test.cc (right):

https://codereview.chromium.org/2992483002/diff/1/runtime/vm/stub_code_arm64_...
runtime/vm/stub_code_arm64_test.cc:97: Assembler _assembler_;
On 2017/07/26 16:12:23, zra wrote:
> It seems like giving this a weird name might be unnecessary. Can this be
changed
> to _assembler_. Also above in TEST_CASE(CallRuntimeStubCode)?

Done.

[alexmarkov, 2017-07-26 20:15:13]

Description was changed from

==========
[vm] Update runtime/vm/stub_code_<arch>_test to avoid using Bigints

In preparation for limiting Dart integers to 64 bits, test for stub
code generation is updated to avoid using Bigints.
Instead of calling kBigintCompareRuntimeEntry leaf runtime entry,
this test now calls kCaseInsensitiveCompareUC16RuntimeEntry.

Issue: https://github.com/dart-lang/sdk/issues/30103
==========

to

==========
[vm] Update runtime/vm/stub_code_<arch>_test to avoid using Bigints

In preparation for limiting Dart integers to 64 bits, test for stub
code generation is updated to avoid using Bigints.
Instead of calling kBigintCompareRuntimeEntry leaf runtime entry,
this test now calls kCaseInsensitiveCompareUC16RuntimeEntry.

R=zra@google.com

Issue: https://github.com/dart-lang/sdk/issues/30103
Committed:
https://github.com/dart-lang/sdk/commit/da654d9a5f387e54d7a991df7d3ed19b5230d8cf
==========

[alexmarkov, 2017-07-26 20:15:14]

Committed patchset #2 (id:20001) manually as
da654d9a5f387e54d7a991df7d3ed19b5230d8cf (presubmit successful).