Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2992463003: Update linter engine to use driver (linter#743). (Closed)

Created:
3 years, 5 months ago by pquitslund
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -83 lines) Patch
M pkg/analyzer/lib/src/lint/analysis.dart View 9 chunks +41 lines, -59 lines 0 comments Download
M pkg/analyzer/lib/src/lint/linter.dart View 4 chunks +11 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/lint/project.dart View 4 chunks +32 lines, -14 lines 0 comments Download
M pkg/analyzer/test/src/lint/project_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
pquitslund
3 years, 5 months ago (2017-07-25 20:55:34 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-25 21:00:02 UTC) #4
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-07-25 21:06:56 UTC) #5
pquitslund
3 years, 5 months ago (2017-07-25 21:23:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b72742e8dad52f1e499fea6202b1977c16c2c493 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698