Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2992383002: Support use of dill in TypeEnv tests (Closed)

Created:
3 years, 4 months ago by Johnni Winther
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -85 lines) Patch
M tests/compiler/dart2js/class_set_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/equivalence/id_equivalence_helper.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/instantiated_classes_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/jsinterop/world_test.dart View 3 chunks +25 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_from_dill_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/compile_from_dill_test_helper.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/compiler_helper.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/mixin_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/compiler/dart2js/members_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/needs_no_such_method_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/subtypeset_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/type_mask2_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/type_test_helper.dart View 4 chunks +70 lines, -39 lines 0 comments Download
M tests/compiler/dart2js/union_type_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/world_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 4 months ago (2017-08-09 08:17:04 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 4 months ago (2017-08-09 16:05:11 UTC) #3
Johnni Winther
3 years, 4 months ago (2017-08-10 07:58:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
437b00c9e82abaa9203e4eb3f36d51a5d3056170 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698