Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2992353002: Invoke copy_tree.py only once to collect all input file lists. (Closed)

Created:
3 years, 4 months ago by zra
Modified:
3 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Invoke copy_tree.py only once to collect all input file lists. fixes #30105 R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/63b9312e1bb82332314bbd844f11a352d76546ee

Patch Set 1 #

Total comments: 3

Patch Set 2 : Cleanup #

Patch Set 3 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -105 lines) Patch
M build/copy_tree.gni View 1 3 chunks +55 lines, -7 lines 0 comments Download
M sdk/BUILD.gn View 1 2 6 chunks +97 lines, -76 lines 0 comments Download
M tools/copy_tree.py View 5 chunks +76 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 4 months ago (2017-08-04 22:52:49 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/2992353002/diff/1/sdk/BUILD.gn File sdk/BUILD.gn (right): https://codereview.chromium.org/2992353002/diff/1/sdk/BUILD.gn#newcode242 sdk/BUILD.gn:242: # A scope containing a single value "sources" ...
3 years, 4 months ago (2017-08-07 22:20:20 UTC) #3
zra
https://codereview.chromium.org/2992353002/diff/1/sdk/BUILD.gn File sdk/BUILD.gn (right): https://codereview.chromium.org/2992353002/diff/1/sdk/BUILD.gn#newcode232 sdk/BUILD.gn:232: template("copy_trees") { I moved this to copy_tree.gni https://codereview.chromium.org/2992353002/diff/1/sdk/BUILD.gn#newcode242 sdk/BUILD.gn:242: ...
3 years, 4 months ago (2017-08-09 18:05:01 UTC) #4
zra
3 years, 4 months ago (2017-08-09 18:14:08 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
63b9312e1bb82332314bbd844f11a352d76546ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698