Attempts to fix bugs introduced in 8b6fcf50e85d.

Attempts to fix bugs introduced in 8b6fcf50e85d.

Removes a call that erroneously changes top_ in Scavenger.
Removes FlushTLS and UnflushTLS from UsedInWords.
Reverts commit 0b0f07d303bd22d1c84106a9035ffc803d7852bb.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/7568e1f18e39dcaaf5d718ab6d8e150a976be1c7

[danunez, 2017-08-04 22:18:03]

Passes the reproducible tests on the local machine.

[rmacnak, 2017-08-04 23:02:15]

lgtm

https://codereview.chromium.org/2992343002/diff/1/runtime/vm/scavenger.cc
File runtime/vm/scavenger.cc (right):

https://codereview.chromium.org/2992343002/diff/1/runtime/vm/scavenger.cc#new...
runtime/vm/scavenger.cc:732: void Scavenger::UnflushTLS(uword value) const {
This only contains asserts now. Remove to rename to something that doesn't
suggest it has a side-effect.

[danunez, 2017-08-05 16:45:48]

Description was changed from

==========
Attempts to fix bugs introduced in 0b0f07d303.

Removes a call that erroneously changes top_ in Scavenger.
Removes FlushTLS and UnflushTLS from UsedInWords.
Reverts commit 0b0f07d303bd22d1c84106a9035ffc803d7852bb.

R=rmacnak@google.com
==========

to

==========
Attempts to fix bugs introduced in 8b6fcf50e85d.

Removes a call that erroneously changes top_ in Scavenger.
Removes FlushTLS and UnflushTLS from UsedInWords.
Reverts commit 0b0f07d303bd22d1c84106a9035ffc803d7852bb.

R=rmacnak@google.com
==========

[danunez, 2017-08-05 16:46:08]

Description was changed from

==========
Attempts to fix bugs introduced in 8b6fcf50e85d.

Removes a call that erroneously changes top_ in Scavenger.
Removes FlushTLS and UnflushTLS from UsedInWords.
Reverts commit 0b0f07d303bd22d1c84106a9035ffc803d7852bb.

R=rmacnak@google.com
==========

to

==========
Attempts to fix bugs introduced in 8b6fcf50e85d.

Removes a call that erroneously changes top_ in Scavenger.
Removes FlushTLS and UnflushTLS from UsedInWords.
Reverts commit 0b0f07d303bd22d1c84106a9035ffc803d7852bb.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7568e1f18e39dcaaf5d718ab6d8e150a976be1c7
==========

[danunez, 2017-08-05 16:46:09]

Committed patchset #2 (id:20001) manually as
7568e1f18e39dcaaf5d718ab6d8e150a976be1c7 (presubmit successful).