Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 299233002: Revert of cc: Stop blocking the main thread in CreateAndInitializeOutputSurface. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, boliu, brianderson, vmpstr
Visibility:
Public.

Description

Revert of cc: Stop blocking the main thread in CreateAndInitializeOutputSurface. (https://codereview.chromium.org/287193003/) Reason for revert: This may be causing mac browser test flakiness: https://code.google.com/p/chromium/issues/detail?id=376649 Original issue's description: > cc: Stop blocking the main thread in CreateAndInitializeOutputSurface. > > The ThreadProxy does not need to block the main thread anymore, instead > have it post back DidInitializeOutputSurface() with the result of the > process. > > We would delete all contents textures on the compositor thread during > OutputSurface creation, which doesn't really make sense, cuz the > ResourceProvider won't be the same one anymore, and this required > blocking the thread. > > We also notified the main thread that the OutputSurface was lost when > creating the new output surface. > > Instead, post a DidLoseOutputSurface() to the main thread to inform > the LayerTreeHost right away, and have that block and clean up > the contents textures immediately (to be removed when we always do > impl-side painting). > > R=enne > BUG=374287 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272276 TBR=enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=374287 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272580

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -76 lines) Patch
M cc/scheduler/scheduler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/trees/thread_proxy.h View 3 chunks +7 lines, -6 lines 0 comments Download
M cc/trees/thread_proxy.cc View 5 chunks +76 lines, -70 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danakj
Created Revert of cc: Stop blocking the main thread in CreateAndInitializeOutputSurface.
6 years, 7 months ago (2014-05-23 19:45:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/299233002/1
6 years, 7 months ago (2014-05-23 19:45:54 UTC) #2
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 19:47:55 UTC) #3
Message was sent while issue was closed.
Change committed as 272580

Powered by Google App Engine
This is Rietveld 408576698