Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 2992243002: Add a test to ensure that error codes are not being missed and add missed error codes (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a test to ensure that error codes are not being missed and add missed error codes R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/defb2990d20387bf1c760297c8999fed7100a555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/analysis_options/error/option_codes.dart View 4 chunks +33 lines, -32 lines 0 comments Download
M pkg/analyzer/lib/src/error/codes.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/test_all.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-08-03 21:32:44 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-08-03 23:21:02 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-08-04 14:45:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
defb2990d20387bf1c760297c8999fed7100a555 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698