Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2992173002: Get logger / fileSystem / byteStore from ProcessedOptions. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/front_end/lib/src/incremental/kernel_driver.dart View 3 chunks +8 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/incremental_kernel_generator_impl.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/front_end/test/src/incremental/kernel_driver_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-08-01 21:44:36 UTC) #1
Siggi Cherem (dart-lang)
lgtm Thanks
3 years, 4 months ago (2017-08-01 21:58:34 UTC) #2
scheglov
3 years, 4 months ago (2017-08-01 23:19:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
58df70b83be1cdee23870132d9494c892097da5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698