Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2055)

Issue 2992153002: Fixes bug in calculation of memory used by new space (Closed)

Created:
3 years, 4 months ago by danunez
Modified:
3 years, 4 months ago
Reviewers:
cbernaschina, rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fixes bug in calculation of memory used by new space Changes Scavenger to use mutator's top_ to calculate memory used in new space instead of the Scavenger's when the VM is not scavenging. Closes https://github.com/dart-lang/sdk/issues/30311 R=cbernaschina@google.com, rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/044f818f014b4879504ad20f2113c7df03f99c79

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M runtime/vm/scavenger.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/scavenger.cc View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danunez
3 years, 4 months ago (2017-08-01 20:19:17 UTC) #1
rmacnak
lgtm
3 years, 4 months ago (2017-08-01 20:27:47 UTC) #2
danunez
3 years, 4 months ago (2017-08-01 20:29:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
044f818f014b4879504ad20f2113c7df03f99c79 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698