Issue 2992143002: Resynthesize type literals from Kernel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2992143002: Resynthesize type literals from Kernel. (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Resynthesize type literals from Kernel. Most tests still fail, because in Kernel typedef(s) are stored as explicit FunctionType(s), i.e. we lose their names. I'm going to amend this in the next CL. R=ahe@google.com, brianwilkerson@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/d632e82cd3243ee46a034dc49d1ad2e97a51dc3d

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	pkg/analyzer/lib/src/kernel/resynthesize.dart	View		2 chunks	+13 lines, -0 lines	0 comments	Download
	M	pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart	View		1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 4 months ago (2017-08-01 18:28:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d632e82cd3243ee46a034dc49d1ad2e97a51dc3d (presubmit successful).