Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 2992073002: FE: let targets override whether imports to internal platform libraries (dart:_foo) are allowed. (Closed)

Created:
3 years, 4 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 4 months ago
Reviewers:
ahe, sra1
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, Johnni Winther
Target Ref:
refs/heads/master
Visibility:
Public.

Description

FE: let targets override whether imports to internal platform libraries (dart:_foo) are allowed. Override this in Dart2jsTarget to allow it in the dart2js_native test suite. R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/e1bccfc857a2498db16e3b490f0d14bda46d0fdf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -80 lines) Patch
M pkg/compiler/lib/src/kernel/dart2js_target.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/kernel/lib/target/targets.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 2 chunks +75 lines, -77 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-07-31 22:11:19 UTC) #7
sra1
lgtm
3 years, 4 months ago (2017-07-31 22:13:49 UTC) #8
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-07-31 22:23:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:80001) manually as
e1bccfc857a2498db16e3b490f0d14bda46d0fdf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698