Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Issue 2992053002: Resynthesize combinators for import/export directives from Kernel. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -49 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 7 chunks +72 lines, -9 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_kernel_test.dart View 3 chunks +0 lines, -35 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 4 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 4 months ago (2017-07-31 16:43:51 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-07-31 16:53:20 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 28d774a792e8e7d8a7511ff6cc862d18116425dd (presubmit successful).
3 years, 4 months ago (2017-07-31 17:02:48 UTC) #4
Siggi Cherem (dart-lang)
3 years, 4 months ago (2017-07-31 17:18:23 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698