Source/bindings/scripts/code_generator_v8.py - Issue 299203002: Support per-overload [RuntimeEnabled] extended attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 299203002: Support per-overload [RuntimeEnabled] extended attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: refactor runtime_enabled() filtering Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/code_generator_v8.py

diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py

index d6b89f599ee9c823f1d9e34324f5b8565dbb909e..778a87ec79b9d11b1959bd6d4f80820616e90b29 100644

--- a/Source/bindings/scripts/code_generator_v8.py

+++ b/Source/bindings/scripts/code_generator_v8.py

@@ -187,8 +187,9 @@ def runtime_enabled_if(code, runtime_enabled_function_name):

return code

# Indent if statement to level of original code

indent = re.match(' *', code).group(0)

- return ('%sif (%s())\n' % (indent, runtime_enabled_function_name) +

- ' %s' % code)

+ return ('%sif (%s()) {\n' % (indent, runtime_enabled_function_name) +

+ ' %s\n' % '\n '.join(code.splitlines()) +

+ '%s}\n' % indent)

################################################################################

« no previous file with comments | « no previous file | Source/bindings/scripts/v8_interface.py » ('j') | Source/bindings/templates/interface.cpp » ('J')