Source/bindings/scripts/v8_interface.py - Issue 299203002: Support per-overload [RuntimeEnabled] extended attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 299203002: Support per-overload [RuntimeEnabled] extended attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: move comment Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/scripts/code_generator_v8.py ('k') | Source/bindings/templates/interface.cpp » ('j') | Source/bindings/tests/results/V8TestObject.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index d8ff7f3c3edd960b42cedadfa772eaa8d009038a..610fbc5c04a6ed70a7315cb159a1f22fff83a4c8 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -753,7 +753,9 @@ def resolution_tests_methods(effective_overloads):

pass

# (Perform automatic type conversion, in order. If any of these match,

- # that’s the end, and no other tests are needed.)

+ # that’s the end, and no other tests are needed.) To keep this code simple,

+ # we rely on the C++ compiler's dead code elimination to deal with the

+ # redundancy if both cases below trigger.

# 11. Otherwise: if there is an entry in S that has one of the following

# types at position i of its type list,

@@ -763,7 +765,6 @@ def resolution_tests_methods(effective_overloads):

method = next(method for idl_type, method in idl_types_methods

if idl_type.name == 'String' or idl_type.is_enum)

yield 'true', method

- return

except StopIteration:

pass

@@ -774,7 +775,6 @@ def resolution_tests_methods(effective_overloads):

method = next(method for idl_type, method in idl_types_methods

if idl_type.is_numeric_type)

yield 'true', method

- return

except StopIteration:

pass

« no previous file with comments | « Source/bindings/scripts/code_generator_v8.py ('k') | Source/bindings/templates/interface.cpp » ('j') | Source/bindings/tests/results/V8TestObject.cpp » ('J')