Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: Source/bindings/templates/methods.cpp

Issue 299203002: Support per-overload [RuntimeEnabled] extended attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebased Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/methods.cpp
diff --git a/Source/bindings/templates/methods.cpp b/Source/bindings/templates/methods.cpp
index 9affae262495d67d4fd6fdb460ec011387010573..db337ff602da8ded932cf583499adace02adb993 100644
--- a/Source/bindings/templates/methods.cpp
+++ b/Source/bindings/templates/methods.cpp
@@ -351,6 +351,7 @@ static void {{overloads.name}}Method{{world_suffix}}(const v8::FunctionCallbackI
{# Then resolve by testing argument #}
{% for test, method in tests_methods %}
{# 10. If i = d, then: #}
Nils Barth (inactive) 2014/06/12 11:45:06 Could you move this comment up?
Jens Widell 2014/06/12 12:04:38 How far up? :-)
Nils Barth (inactive) 2014/06/12 12:20:27 I love it when I say "Jump" and you reply "How hig
+ {% filter runtime_enabled(not overloads.runtime_enabled_function_all and method.runtime_enabled_function) %}
Nils Barth (inactive) 2014/06/12 11:45:06 wrap?
if ({{test}}) {
{% if method.measure_as and not overloads.measure_all_as %}
UseCounter::count(callingExecutionContext(isolate), UseCounter::{{method.measure_as}});
@@ -361,6 +362,7 @@ static void {{overloads.name}}Method{{world_suffix}}(const v8::FunctionCallbackI
{{method.name}}{{method.overload_index}}Method{{world_suffix}}(info);
return;
}
+ {% endfilter %}
{% endfor %}
break;
{% endfor %}

Powered by Google App Engine
This is Rietveld 408576698