Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Unified Diff: Source/bindings/scripts/code_generator_v8.py

Issue 299203002: Support per-overload [RuntimeEnabled] extended attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_interface.py » ('j') | Source/bindings/scripts/v8_interface.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.py
diff --git a/Source/bindings/scripts/code_generator_v8.py b/Source/bindings/scripts/code_generator_v8.py
index 37253ba582581d74d05b6cd002385d163791183d..97753cf56653b444cc43942faaee3713fd8e5670 100644
--- a/Source/bindings/scripts/code_generator_v8.py
+++ b/Source/bindings/scripts/code_generator_v8.py
@@ -184,8 +184,16 @@ def runtime_enabled_if(code, runtime_enabled_function_name):
return code
# Indent if statement to level of original code
indent = re.match(' *', code).group(0)
- return ('%sif (%s())\n' % (indent, runtime_enabled_function_name) +
- ' %s' % code)
+ lines = code.splitlines()
+ if len(lines) > 1:
Nils Barth (inactive) 2014/05/27 06:33:20 It's fine to always use a { } block, so you can el
+ fmt = '%(indent)sif (%(fnname)s()) {\n %(code)s\n%(indent)s}\n'
Nils Barth (inactive) 2014/05/27 06:33:20 Could you use string concatenation and split the s
+ else:
+ fmt = '%(indent)sif (%(fnname)s())\n %(code)s\n'
+ return fmt % {
Nils Barth (inactive) 2014/05/27 06:33:20 Could you use str.format instead of % with a dict?
+ 'indent': indent,
+ 'fnname': runtime_enabled_function_name,
+ 'code': '\n '.join(lines),
+ }
################################################################################
« no previous file with comments | « no previous file | Source/bindings/scripts/v8_interface.py » ('j') | Source/bindings/scripts/v8_interface.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698