pkg/kernel/lib/binary/ast_from_binary.dart - Issue 2991993002: Reapply 47ecf72 after it was reverted in e431e93e872d9a1c97a5177ebb09d5416f1d659a.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/kernel/lib/binary/ast_from_binary.dart

Issue 2991993002: Reapply 47ecf72 after it was reverted in e431e93e872d9a1c97a5177ebb09d5416f1d659a. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/kernel/lib/binary/ast_from_binary.dart

diff --git a/pkg/kernel/lib/binary/ast_from_binary.dart b/pkg/kernel/lib/binary/ast_from_binary.dart

index 47e398ae763ae172caf1ee6fc1e5e8fb225e2b81..04c4b6906effe0196f76caa9b8db05de0f9b155e 100644

--- a/pkg/kernel/lib/binary/ast_from_binary.dart

+++ b/pkg/kernel/lib/binary/ast_from_binary.dart

@@ -525,6 +525,7 @@ class BinaryBuilder {

readUInt(); // parent class binary offset.

var name = readName();

var fileUri = readUriReference();

+ var documentationComment = readStringOrNullIfEmpty();

var annotations = readAnnotationList(node);

debugPath.add(node.name?.name ?? 'field');

var type = readDartType();

@@ -537,6 +538,7 @@ class BinaryBuilder {

node.flags = flags;

node.name = name;

node.fileUri = fileUri;

+ node.documentationComment = documentationComment;

node.annotations = annotations;

node.type = type;

node.initializer = initializer;

@@ -561,6 +563,7 @@ class BinaryBuilder {

var flags = readByte();

readUInt(); // parent class binary offset.

var name = readName();

+ var documentationComment = readStringOrNullIfEmpty();

var annotations = readAnnotationList(node);

debugPath.add(node.name?.name ?? 'constructor');

var function = readFunctionNode();

@@ -579,6 +582,7 @@ class BinaryBuilder {

node.fileEndOffset = fileEndOffset;

node.flags = flags;

node.name = name;

+ node.documentationComment = documentationComment;

node.annotations = annotations;

node.function = function..parent = node;

node.transformerFlags = transformerFlags;

@@ -604,6 +608,7 @@ class BinaryBuilder {

readUInt(); // parent class binary offset.

var name = readName();

var fileUri = readUriReference();

+ var documentationComment = readStringOrNullIfEmpty();

var annotations = readAnnotationList(node);

debugPath.add(node.name?.name ?? 'procedure');

var function = readFunctionNodeOption();

@@ -616,6 +621,7 @@ class BinaryBuilder {

node.flags = flags;

node.name = name;

node.fileUri = fileUri;

+ node.documentationComment = documentationComment;

node.annotations = annotations;

node.function = function;

node.function?.parent = node;

« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »