pkg/front_end/lib/src/fasta/source/outline_builder.dart - Issue 2991993002: Reapply 47ecf72 after it was reverted in e431e93e872d9a1c97a5177ebb09d5416f1d659a.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/source/outline_builder.dart

Issue 2991993002: Reapply 47ecf72 after it was reverted in e431e93e872d9a1c97a5177ebb09d5416f1d659a. (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_target.dart ('k') | pkg/front_end/lib/src/fasta/source/source_library_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/source/outline_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/source/outline_builder.dart b/pkg/front_end/lib/src/fasta/source/outline_builder.dart

index 9458cde75336c55b51ce4e4c030f24de47884895..065020df65c346d373c200f00f13d83b74cbe884 100644

--- a/pkg/front_end/lib/src/fasta/source/outline_builder.dart

+++ b/pkg/front_end/lib/src/fasta/source/outline_builder.dart

@@ -328,8 +328,10 @@ class OutlineBuilder extends UnhandledListener {

int modifiers =

Modifier.validate(pop(), isAbstract: kind == MethodBody.Abstract);

List<MetadataBuilder> metadata = pop();

+ String documentationComment = _getDocumentationComment(beginToken);

checkEmpty(beginToken.charOffset);

library.addProcedure(

+ documentationComment,

metadata,

modifiers,

returnType,

@@ -429,7 +431,9 @@ class OutlineBuilder extends UnhandledListener {

modifiers &= ~abstractMask;

}

List<MetadataBuilder> metadata = pop();

+ String documentationComment = _getDocumentationComment(beginToken);

library.addProcedure(

+ documentationComment,

metadata,

modifiers,

returnType,

@@ -722,7 +726,9 @@ class OutlineBuilder extends UnhandledListener {

TypeBuilder type = pop();

int modifiers = Modifier.validate(pop());

List<MetadataBuilder> metadata = pop();

- library.addFields(metadata, modifiers, type, fieldsInfo);

+ String documentationComment = _getDocumentationComment(beginToken);

+ library.addFields(

+ documentationComment, metadata, modifiers, type, fieldsInfo);

checkEmpty(beginToken.charOffset);

}

@@ -733,7 +739,9 @@ class OutlineBuilder extends UnhandledListener {

TypeBuilder type = pop();

int modifiers = Modifier.validate(pop());

List<MetadataBuilder> metadata = pop();

- library.addFields(metadata, modifiers, type, fieldsInfo);

+ String documentationComment = _getDocumentationComment(beginToken);

+ library.addFields(

+ documentationComment, metadata, modifiers, type, fieldsInfo);

}

@override

@@ -793,7 +801,9 @@ class OutlineBuilder extends UnhandledListener {

var name = pop();

int modifiers = Modifier.validate(pop());

List<MetadataBuilder> metadata = pop();

+ String documentationComment = _getDocumentationComment(beginToken);

library.addFactoryMethod(

+ documentationComment,

metadata,

modifiers,

name,