Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2991913002: Replace typed_mock with mockito in analyzer. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -74 lines) Patch
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/bazel_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 2 chunks +0 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/cache_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/base.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/driver_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/summary/package_bundle_reader_test.dart View 7 chunks +18 lines, -16 lines 0 comments Download
M pkg/analyzer/test/src/task/dart_work_manager_test.dart View 9 chunks +15 lines, -13 lines 0 comments Download
M pkg/analyzer/test/src/task/driver_test.dart View 12 chunks +25 lines, -17 lines 0 comments Download
M pkg/analyzer/test/src/task/general_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/src/task/html_work_manager_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/src/task/options_work_manager_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-07-27 22:04:08 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-07-27 23:00:17 UTC) #2
scheglov
3 years, 4 months ago (2017-07-27 23:15:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bf25080cc161610cbe9f89e0368e0dcf555783e6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698