Add Closure call method to created closure class

Add Closure call method to created closure class.


BUG=
R=sra@google.com

Committed: https://github.com/dart-lang/sdk/commit/a1f911c5990e353f735841c9c28728246830c0bc

[Emily Fortuna, 2017-07-27 21:05:51]

efortuna@google.com changed reviewers:
+ sigmund@google.com, sra@google.com

[Emily Fortuna, 2017-07-27 21:05:52]

NOT FOR REVIEW! This is just for discussion.

https://codereview.chromium.org/2991903002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_map_impl.dart (right):

https://codereview.chromium.org/2991903002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:2009: _memberData.add(new
MemberData(
commenting out this line makes the FunctionNode issue go away

https://codereview.chromium.org/2991903002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_map_impl.dart:2040: _memberData.add(new
MemberData(
commenting out this line makes the variableDeclaration issue go away.

https://codereview.chromium.org/2991903002/diff/1/pkg/compiler/lib/src/ssa/bu...
File pkg/compiler/lib/src/ssa/builder_kernel.dart (right):

https://codereview.chromium.org/2991903002/diff/1/pkg/compiler/lib/src/ssa/bu...
pkg/compiler/lib/src/ssa/builder_kernel.dart:160: //  buildFunctionNode(target);
// eh?
here's where we need to properly deal with the closure field and call, but we're
currently not, and we make the graph unhappy.

[Emily Fortuna, 2017-07-27 21:07:30]

oh, and I should mention the easiest way to hit this error is to run:

python tools/test.py -m release --checked dart2js/kernel/compile_from_dill_test

[Emily Fortuna, 2017-07-28 18:52:04]

Patchset #3 (id:40001) has been deleted

[Emily Fortuna, 2017-07-28 21:54:17]

Patchset #2 (id:20001) has been deleted

[Emily Fortuna, 2017-07-28 21:54:26]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-07-28 21:54:32]

Patchset #1 (id:60001) has been deleted

[Emily Fortuna, 2017-07-28 21:54:38]

Patchset #1 (id:80001) has been deleted

[Emily Fortuna, 2017-07-28 21:56:21]

Description was changed from

==========
Try to register the closure class fields and call but hit some errors when we
try to build in the SSA builder.


BUG=
==========

to

==========
Add Closure call method to created closure class.


BUG=
==========

[Emily Fortuna, 2017-07-28 21:56:21]

efortuna@google.com changed reviewers:
+ johnniwinther@google.com
- sigmund@google.com

[Emily Fortuna, 2017-07-28 21:56:52]

Patchset #1 (id:100001) has been deleted

[Emily Fortuna, 2017-07-28 22:03:52]

Patchset #1 (id:120001) has been deleted

[sra1, 2017-07-28 22:09:40]

LGTM with a few nits

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_model/elements.dart (right):

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_model/elements.dart:523: class ClosureCall extends
JFunction {
I think 'JClosureCallMethod' or 'JClosureFunction' would be better names.

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_model/js_strategy.dart (right):

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_model/js_strategy.dart:391: ir.FunctionNode
originalClosureCall,
originalCallFunctionNode?

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_model/locals.dart (right):

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_model/locals.dart:135: Local
getLocalFunction(ir.TreeNode node) {
Can we split this into two methods for FunctionExpression and
FunctionDeclaration.

Do we even need a Local for a FunctionExpression?

[Emily Fortuna, 2017-07-28 23:17:08]

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_model/elements.dart (right):

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_model/elements.dart:523: class ClosureCall extends
JFunction {
On 2017/07/28 22:09:40, sra1 wrote:
> I think 'JClosureCallMethod' or 'JClosureFunction' would be better names.

fixed.

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_model/js_strategy.dart (right):

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_model/js_strategy.dart:391: ir.FunctionNode
originalClosureCall,
On 2017/07/28 22:09:40, sra1 wrote:
> originalCallFunctionNode?

Done.

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
File pkg/compiler/lib/src/js_model/locals.dart (right):

https://codereview.chromium.org/2991903002/diff/140001/pkg/compiler/lib/src/j...
pkg/compiler/lib/src/js_model/locals.dart:135: Local
getLocalFunction(ir.TreeNode node) {
On 2017/07/28 22:09:40, sra1 wrote:
> Can we split this into two methods for FunctionExpression and
> FunctionDeclaration.
> 
> Do we even need a Local for a FunctionExpression?

Added a TODO, for discussion with Johnni.

[Emily Fortuna, 2017-07-30 21:08:44]

Description was changed from

==========
Add Closure call method to created closure class.


BUG=
==========

to

==========
Add Closure call method to created closure class.


BUG=
R=sra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a1f911c5990e353f735841c9c28728246830c0bc
==========

[Emily Fortuna, 2017-07-30 21:08:45]

Committed patchset #2 (id:160001) manually as
a1f911c5990e353f735841c9c28728246830c0bc (presubmit successful).