Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 2991893002: Remove the uri from the ImportedElements object in the experimental spec API (Closed)

Created:
3 years, 4 months ago by Brian Wilkerson
Modified:
3 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the uri from the ImportedElements object in the experimental spec API R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c618032a6913722fc502362d6fece3a59a9a0695

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -73 lines) Patch
M pkg/analysis_server/doc/api.html View 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/analysis_server/lib/protocol/protocol_generated.dart View 9 chunks +2 lines, -29 lines 0 comments Download
M pkg/analysis_server/test/integration/support/protocol_matchers.dart View 1 chunk +3 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/src/computer/import_elements_computer_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/tool/spec/generated/java/types/ImportedElements.java View 7 chunks +2 lines, -21 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 4 months ago (2017-07-27 19:48:24 UTC) #2
scheglov
LGTM
3 years, 4 months ago (2017-07-27 19:50:08 UTC) #3
Brian Wilkerson
3 years, 4 months ago (2017-07-27 19:52:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c618032a6913722fc502362d6fece3a59a9a0695 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698