Issue 2991873002: Store dependency libraries canonical names during limited store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2991873002: Store dependency libraries canonical names during limited store. (Closed)

Created:
3 years, 4 months ago by scheglov

Modified:
3 years, 4 months ago

Reviewers:
ahe, Siggi Cherem (dart-lang), Brian Wilkerson

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -12 lines)			Patch
	M	pkg/front_end/test/src/incremental/kernel_driver_test.dart	View		1 chunk	+37 lines, -0 lines	0 comments	Download
	M	pkg/kernel/lib/binary/limited_ast_to_binary.dart	View		3 chunks	+18 lines, -12 lines	0 comments	Download

Total messages: 5 (1 generated)

Brian Wilkerson

I don't think I have the background for this review.

3 years, 4 months ago (2017-07-27 16:53:16 UTC) #2

scheglov

3 years, 4 months ago (2017-07-27 18:22:11 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f6038897669b67dfa03893009b21ee0bf97238c2 (presubmit successful).