Issue 2991813002: [VM arm assembler] Do not use addressing mode 2 with instructions ldrh, ldrsh,

Issue 2991813002: [VM arm assembler] Do not use addressing mode 2 with instructions ldrh, ldrsh, (Closed)

Created:
3 years, 4 months ago by regis

Modified:
3 years, 4 months ago

Reviewers:
zra, alexmarkov

CC:
reviews_dartlang.org, vm-dev_dartlang.org, aam

Target Ref:
refs/heads/master

Visibility:
Public.

[VM arm assembler] Do not use addressing mode 2 with instructions ldrh, ldrsh, strh, and ldrsb, but use addressing mode 3 (fixes #30260). Note that the instructions ldrb and strb use addressing mode 2 (no change). R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/d6a39354ce16003562d43727058816753d2ebefd

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	runtime/vm/assembler_arm.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 7 (4 generated)

regis

3 years, 4 months ago (2017-07-26 21:17:26 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d6a39354ce16003562d43727058816753d2ebefd (presubmit successful).