Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2991803003: Report more heuristics for tests that require manual work. (Closed)

Created:
3 years, 4 months ago by Bob Nystrom
Modified:
3 years, 4 months ago
Reviewers:
bkonyi, kevmoo
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report more heuristics for tests that require manual work. If the contents of a test mention "checked", "TypeError", or "AbstractClassInstantiationError", they will need some work. Tell the user about those. R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/158e95a9401e7aba574434dac1a6820fe40be849

Patch Set 1 #

Total comments: 1

Patch Set 2 : Tweaks. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -41 lines) Patch
M tools/migration/bin/migrate_batch.dart View 1 12 chunks +45 lines, -40 lines 0 comments Download
M tools/migration/lib/src/log.dart View 1 chunk +1 line, -1 line 0 comments Download
A tools/migration/lib/src/validate.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bob Nystrom
This should hopefully catch a few more cases where we know some manual effort is ...
3 years, 4 months ago (2017-07-26 17:12:35 UTC) #2
bkonyi
LGTM https://codereview.chromium.org/2991803003/diff/1/tools/migration/bin/migrate_batch.dart File tools/migration/bin/migrate_batch.dart (right): https://codereview.chromium.org/2991803003/diff/1/tools/migration/bin/migrate_batch.dart#newcode252 tools/migration/bin/migrate_batch.dart:252: new Directory(p.dirname(p.join(testRoot, to))).createSync(recursive: true); Nice! I just ran ...
3 years, 4 months ago (2017-07-26 17:59:26 UTC) #3
Bob Nystrom
3 years, 4 months ago (2017-07-26 19:57:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
158e95a9401e7aba574434dac1a6820fe40be849 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698