Adjusted status for corelib_2/symbol_test for !$strong.

Adjusted status for corelib_2/symbol_test for !$strong.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/472bf54d9659b7b1b1b0bde6f918ecf2ab48ebab

[eernst, 2017-07-26 13:20:02]

eernst@google.com changed reviewers:
+ rnystrom@google.com

[eernst, 2017-07-26 13:20:02]

The new section on strong mode only (`[!$strong]`) might be expressed as

[ !$strong || $compiler == dart2js || (($compiler == none || $compiler ==
precompiler || $compiler == app_jit) && $runtime != drt) ]

in order to match the current semantics precisely (and in order to ensure that
non-strong mode is assumed even in the case where `--strong` is passed to
dart2js etc.), but since this is inherently a non-strong mode property I chose
to check for the simple `[!$strong]` case, and then we could say that it's up to
the testing infrastructure to let `$compiler == dart2js` etc. imply `!$strong`
(or just never do `tools/test.py -cdart2js --strong ..`), such that it will
_continue_ to work even when dart2js starts accepting `--strong` (and doing it).

[Bob Nystrom, 2017-07-26 16:39:37]

I think there is a simpler fix we should do here. There's no need to test that
passing the wrong type to new Symbol() produces a compile error. It's a basic
feature of the type system that passing an argument of the wrong type is an
error. We don't need to explicitly test that for every parameter in every method
in the public API.

So I think we can remove this section entirely:

  try {
    var y = 0;
    print(new Symbol(y)); //# 04: compile-time error
    throw 'Expected a NoSuchMethodError or a TypeError'; //# 04: ok
  } on NoSuchMethodError {
    print('Caught NoSuchMethodError');
  } on TypeError {
    print('Caught TypeError');
  }

Would you mind doing that?

[eernst, 2017-07-27 17:32:10]

Patchset #2 (id:20001) has been deleted

[eernst, 2017-07-27 17:32:26]

Right, it does not contribute anything to test that a static type error is
detected at compile time.

The faithful transformation of this test from Dart 1.x to strong mode would
actually be to have `dynamic y = 0;` rather than `var y = 0;`, and in this case
it would test the same thing that it was designed to test.

However, that only makes sense if we have production mode, because the test
makes the distinction between getting a NoSuchMethodError (in production mode)
and a TypeError (in checked mode).

When all modes are checked, it's just another test of an argument type check.

Gone it is! ;-)

[Bob Nystrom, 2017-07-27 19:02:50]

LGTM!

[eernst, 2017-07-28 14:10:23]

Description was changed from

==========
Adjusted status for corelib_2/symbol_test for !$strong.
==========

to

==========
Adjusted status for corelib_2/symbol_test for !$strong.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/472bf54d9659b7b1b1b0bde6f918ecf2ab48ebab
==========

[eernst, 2017-07-28 14:10:24]

Committed patchset #2 (id:40001) manually as
472bf54d9659b7b1b1b0bde6f918ecf2ab48ebab (presubmit successful).