Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2991773002: Replace typed_mock with mockito in analysis_server. (Closed)

Created:
3 years, 4 months ago by scheglov
Modified:
3 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -44 lines) Patch
M pkg/analysis_server/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/analysis/update_content_test.dart View 4 chunks +0 lines, -20 lines 0 comments Download
M pkg/analysis_server/test/channel/byte_stream_channel_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analysis_server/test/mocks.dart View 6 chunks +16 lines, -18 lines 0 comments Download
M pkg/analysis_server/test/protocol_server_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 4 months ago (2017-07-26 00:21:44 UTC) #1
Brian Wilkerson
lgtm
3 years, 4 months ago (2017-07-26 13:41:46 UTC) #2
scheglov
3 years, 4 months ago (2017-07-26 15:14:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1589bf87951e8b51729d1775746c3a6f5aa183e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698