Issue 2991763002: Remove old dead tag handler.

Issue 2991763002: Remove old dead tag handler. (Closed)

Created:
3 years, 4 months ago by rmacnak

Modified:
3 years, 4 months ago

Reviewers:
zra, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove old dead tag handler. R=asiva@google.com, zra@google.com Committed: https://github.com/dart-lang/sdk/commit/02ec4f494e1221206fa88d0b68e1f571eee2e9b0

Patch Set 1 #

Total comments: 1

Created: 3 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -110 lines)			Patch
M	runtime/bin/dart_product_entries.txt	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/bin/dartutils.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View	2 chunks	+0 lines, -105 lines	1 comment	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

lgtm https://codereview.chromium.org/2991763002/diff/1/runtime/bin/dartutils.cc File runtime/bin/dartutils.cc (left): https://codereview.chromium.org/2991763002/diff/1/runtime/bin/dartutils.cc#oldcode351 runtime/bin/dartutils.cc:351: DartUtils::NewString("_loadDataAsync"), kNumArgs, I couldn't find this Dart function. ...

3 years, 4 months ago (2017-07-26 16:14:25 UTC) #4

rmacnak

On 2017/07/26 16:14:25, zra wrote: > lgtm > > https://codereview.chromium.org/2991763002/diff/1/runtime/bin/dartutils.cc > File runtime/bin/dartutils.cc (left): > ...

3 years, 4 months ago (2017-07-26 16:52:41 UTC) #5

rmacnak

3 years, 4 months ago (2017-07-26 16:53:10 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
02ec4f494e1221206fa88d0b68e1f571eee2e9b0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages