Issue 299173002: Some progress on translating toolchain.gypi to gn

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 299173002: Some progress on translating toolchain.gypi to gn (Closed)

Created:
6 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 7 months ago

Reviewers:
brettw

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Some progress on translating toolchain.gypi to gn BUG=none R=brettw@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=21478

Patch Set 2 : updates #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+99 lines, -36 lines)			Patch
	M	BUILD.gn	View	1	15 chunks	+99 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

lgtm https://codereview.chromium.org/299173002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/299173002/diff/1/BUILD.gn#newcode114 BUILD.gn:114: if (v8_target_arch == "ia32") { GN uses x86 ...

6 years, 7 months ago (2014-05-23 18:24:32 UTC) #2

jochen (gone - plz use gerrit)

6 years, 7 months ago (2014-05-26 07:29:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r21478 (presubmit successful).

Expand Messages | Collapse Messages

Issue 299173002: Some progress on translating toolchain.gypi to gn (Closed)

Description

Patch Set 1 #

Patch Set 2 : updates #

Messages